streams v3 compat & add readable-stream #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s api across node versions
jaawerth
force-pushed
the
add-readable-stream
branch
from
9565dfe to
5d08f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Updated the
readArraymethod to appendnullto the end of the source array. This closes the source stream, allowing tests to pass in the streams v3 API (node 0.12+).Proceeded to swap out the reliance on the core
streammodule forreadable-stream- this will lock the steams API in use to a stable implementation so it will work across node versions (both forward and back - tested as far back as node 0.10.48) even if the streams API undergoes further changes.